[WFLY-2345] Port Offset 0 does not work #5307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a port offset is specified in the socket binding group and the socket binding has a port of 0, then the port offset is not used to calculate the port instead port 0 is bound. This pull request contains three changes: - fix `SocketBinding` to also do offset calculation when the port is 0 - extend `ControllerInitializer` to allow specifing the port offset - add a test in `OtherServicesSubsystemTestCase` Issue: WFLY-2345 https://issues.jboss.org/browse/WFLY-2345
|
Build 1133 is now running using a merge of 8eeb6d6 |
|
Build 1133 outcome was SUCCESS using a merge of 8eeb6d6 |
| @@ -111,7 +111,7 @@ public SocketBindingManager getSocketBindings() { | |||
|
|
|||
| private int calculatePort() { | |||
| int port = this.port; | |||
| if (port > 0 && isFixedPort == false) { | |||
| if (!isFixedPort) { | |||
There was a problem hiding this comment.
Perhaps port <= 0 would be better?
There was a problem hiding this comment.
I don't know if it ever can be negative. The model/schema should validate that's in a valid range.
There was a problem hiding this comment.
It is ok, port 0 is valid, negative ones are not.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a port offset is specified in the socket binding group and the
socket binding has a port of 0, then the port offset is not used to
calculate the port instead port 0 is bound.
This pull request contains three changes:
SocketBindingto also do offset calculation when the port is 0ControllerInitializerto allow specifing the port offsetOtherServicesSubsystemTestCaseIssue: WFLY-2345
https://issues.jboss.org/browse/WFLY-2345