Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-1458] handle the managed container startup timeout properly #5334

Closed
wants to merge 1 commit into from
Closed

[WFLY-1458] handle the managed container startup timeout properly #5334

wants to merge 1 commit into from

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Oct 23, 2013

My proposed fix for https://issues.jboss.org/browse/WFLY-1458. If we decide that this fix is OK, we'll probably need to apply it to ManagedDomainDeployableContainer too.

@Ladicek
[WFLY-1458] handle the managed container startup timeout properly
7b827cb 
The managed container implementation assumes that the check if server
is running

  getManagementClient().isServerInRunningState()

is cheap, while in fact, it doesn't have to be. It's possible for this code
to end up waiting for response that won't come, and the IO will have
to time out. This timeout defaults to 5 seconds.

If this happens, then the container startup timeout, which defaults
to 1 minute, will actually be cca 50x bigger, which is certainly not desired.
@wildfly-ci
Copy link

Build 1179 is now running using a merge of 7b827cb

@wildfly-ci
Copy link

Build 1179 outcome was SUCCESS using a merge of 7b827cb
Summary: Tests passed: 5142, ignored: 90, muted: 5 Build time: 1:46:32

@bstansberry
Copy link
Contributor

Merged.

@Ladicek Ladicek mentioned this pull request Oct 30, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Ladicek @wildfly-ci @bstansberry