New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-2403 Cannot disable a Datasource or XADatasource in standalone mode... #5370
Conversation
Build 1284 is now running using a merge of f6a5a509846bec7ff85ffbfc4860c04cd79a39ff |
Build 1285 is now running using a merge of f6a5a509846bec7ff85ffbfc4860c04cd79a39ff |
@@ -71,6 +70,7 @@ public void execute(final OperationContext context, ModelNode operation) throws | |||
final ModelNode address = operation.require(OP_ADDR); | |||
final String dsName = PathAddress.pathAddress(address).getLastElement().getValue(); | |||
final String jndiName = model.get(JNDI_NAME.getName()).asString(); | |||
model.get(ENABLED).set(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't make model changes in Stage.RUNTIME.
Also, it seems that would only change the model state if context.isResourceServiceRestartAllowed() which will rarely be the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup it's a refuse, sorry. rolling back this file
…ode. It's back to enabled state after server reload.
Build 1288 is now running using a merge of eb72f08 |
Build 1285 outcome was FAILURE using a merge of eb72f08 Build problems:Failed tests detected
Failed tests
|
retest this please On Tue, Oct 29, 2013 at 2:19 PM, jboss-as-pull-request <
|
Build 1292 is now running using a merge of eb72f08 |
Build 1293 is now running using a merge of eb72f08 |
Build 1288 outcome was SUCCESS using a merge of eb72f08 |
Build 1293 outcome was SUCCESS using a merge of eb72f08 |
merged |
.... It's back to enabled state after server reload.