New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-2423: support for resource injection with non java: jndi names; bet... #5445
Conversation
Build 1456 is now running using a merge of 33b0eac77e7288ea9d83d583bd1ad6df40f87705 |
Build 1456 outcome was FAILURE using a merge of 33b0eac77e7288ea9d83d583bd1ad6df40f87705 Build problems:Failed tests detected
Failed tests
|
Retest this please! |
Build 1587 is now running using a merge of 33b0eac77e7288ea9d83d583bd1ad6df40f87705 |
Build 1587 outcome was FAILURE using a merge of 33b0eac77e7288ea9d83d583bd1ad6df40f87705 Build problems:Failed tests detected
Failed tests
|
Build 1770 is now running using a merge of a35d6f9de9d716d3864a1652caba3a3856fda129 |
Build 1770 outcome was SUCCESS using a merge of a35d6f9de9d716d3864a1652caba3a3856fda129 |
Build 1815 is now running using a merge of ecc0d968081e24c645ad11551d5779052ad64e82 |
Build 1815 outcome was SUCCESS using a merge of ecc0d968081e24c645ad11551d5779052ad64e82 |
Build 1915 is now running using a merge of f10da53 |
Build 1915 outcome was FAILURE using a merge of f10da53 Build problems:Failed tests detected
Failed tests
|
retest this please |
Build 1925 is now running using a merge of f10da53 |
Build 1925 outcome was FAILURE using a merge of f10da53 Build problems:Failed tests detected
Failed tests
|
Build 2085 is now running using a merge of 91bb25b |
Build 2085 outcome was FAILURE using a merge of 91bb25b Build problems:Failed tests detected
Failed tests
|
retest this please |
Build 2087 is now running using a merge of 91bb25b |
Build 2087 outcome was SUCCESS using a merge of 91bb25b |
Build 2528 is now running using a merge of 9e07f6c |
Build 2528 outcome was FAILURE using a merge of 9e07f6c Build problems:Failed tests detected
Failed tests
|
Build 2760 is now running using a merge of f40201d |
Build 2760 outcome was FAILURE using a merge of f40201d Build problems:Failed tests detected
Failed tests
|
retest this please |
Build 2777 is now running using a merge of f40201d |
Build 2777 outcome was SUCCESS using a merge of f40201d |
Build 2910 is now running using a merge of a6238cc |
Build 2910 outcome was SUCCESS using a merge of a6238cc |
Build 2941 is now running using a merge of d72793a |
Besides fixing resource injection for non java names, which currently does not works at all for names such as ldap://, and fixing also the URL connection factory support added to WildFly due to TCK7 (currently we do not support a URL referring an already bound through java: name), this PR is also a first step in cleaning/optimizing the resource injection logic, by merging the 2 lookup injection sources type (normal & optional), and sync the logic flow in the 2 deployment processors responsible for setting up resource injection. While the PR diff may confuse a brief review, looking at the full code on the changed classes should provide a much easier to understand (and review) code |
…better approach for detecting url connection factories; cleanup/optimization through resource injection processors logic sync and merge of optional with non-optional lookup injection source
Build 2941 outcome was SUCCESS using a merge of d72793a |
Build 2947 is now running using a merge of e5ba623 |
Build 2947 outcome was SUCCESS using a merge of e5ba623 |
This should be OK to merge |
WFLY-2423: support for resource injection with non java: jndi names; bet...
...ter approach for detecting url connection factories; cleanup/optimization through resource injection processors logic sync and merge of optional with non-optional lookup injection source