WFLY-2912 Generic JMS adapter does not deploy correctly in domain mode. #5903
Conversation
|
Build 2661 is now running using a merge of a83399a |
|
Build 2661 outcome was SUCCESS using a merge of a83399a |
| final ServiceVerificationHandler svh = new ServiceVerificationHandler(); | ||
|
|
||
|
|
||
| ServiceName restartedServiceName = RaOperationUtil.restartIfPresent(context, archiveOrModuleName, name, svh); |
There was a problem hiding this comment.
I don't really understand what is going on here. It looks like the logic is 'if the server is booting restart the service' however I don't really see why this should be necessary, because if the server is booting then there should be no service there yet to restart?
There was a problem hiding this comment.
Well the code is not very self explaining. I'll rework it a bit to make it more readable asap, but le me explain what it's aiming to do: RaOperationUtil.installRaServicesAndDeployFromModule create services for rar deployed as module. This service require an explicit activation (:activate command from CLI) when a configuration is added. In case of boot time both operation need to be executed, and this "restart" service is exactly activating configuration on previous installed service.
As said I'll rework a bit the code to make it more readable (at least w/ some comments).
Thanks to point it out.
|
Build 2917 is now running using a merge of fa29697 |
|
Build 2917 outcome was SUCCESS using a merge of fa29697 |
|
I've checked that the generic JMS RA is correctly deployed in domain mode with that fix. |
| final ServiceVerificationHandler svh = new ServiceVerificationHandler(); | ||
|
|
||
| //Next lines activate configuration on module deployed rar | ||
| //in case there is 2 different resource-adapter config using same module deployed rar |
There was a problem hiding this comment.
This commit fixes the issue of deploying the generic JMS RA in domain mode but I don't understand what is the relation with this comment.
I have only 1 resource-adapter defined (org.jboss.genericjms) in each of my profile. Each server should have only one deployed RA, right?
There was a problem hiding this comment.
You could have multiple config (at least theoretically) for same module RA
|
Bump :) |
WFLY-2912 Generic JMS adapter does not deploy correctly in domain mode.
No description provided.