Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.jboss.org/browse/WFLY-2914 add cli xsd version 1.3 which ... #5905

Merged
merged 1 commit into from May 18, 2014

Conversation

aloubyansky
Copy link
Contributor

...is 1.2 plus vault configuration

Thanks,
Alexey

@wildfly-ci
Copy link

Build 2651 is now running using a merge of d613127

@wildfly-ci
Copy link

Build 2651 outcome was SUCCESS using a merge of d613127
Summary: Tests passed: 5570, ignored: 74 Build time: 1:31:01

@bstansberry
Copy link
Contributor

This shouldn't be merged until master is opened for 9.x. This should go in 9.x as 8.0.1.Final will be produced before any EAP GA release that has this schema in it. If we put 1.3 in a WF .Final and then there needs to be some change in EAP 6.3, EAP will have to move to 1.4.

@n1hility
Copy link
Member

@bstansberry wdyt about this one still. We are already bumping config versions should we let this one in?

@bstansberry
Copy link
Contributor

No, the rationale for not including this is once it's in a .Final release, that number is burned and any further changes needed in EAP 6.3 (which is where 1.3 first appears) will require a version bump. There's no need for 1.3 in 8.0.1 because 2.0 already has the relevant config items.

@aloubyansky is there any difference between this 1.3 and what's currently in 2.0?

@aloubyansky
Copy link
Contributor Author

Yes, new configuration elements related to protocol and named controllers (Darran was working on) and access-control.

@bstansberry
Copy link
Contributor

Thanks. I asked because today we realized we had forward ported a 1.x version of another schema that was identical to its 2.0 version. :)

@n1hility
Copy link
Member

ok well leave it out then

@bstansberry
Copy link
Contributor

Needs a rebase.

@wildfly-ci
Copy link

Build 3720 is now running using a merge of 335be3b

@wildfly-ci
Copy link

Build 3720 outcome was SUCCESS using a merge of 335be3b
Summary: Tests passed: 5791, ignored: 89 Build time: 1:54:48

bstansberry added a commit that referenced this pull request May 18, 2014
@bstansberry bstansberry merged commit 579b668 into wildfly:master May 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants