Audit logging fixes #6001
Merged
Audit logging fixes #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing; something is out of whack in the commit history. |
|
retest this please |
| assert isControllingThread(); | ||
|
|
||
| readOnly = false; |
There was a problem hiding this comment.
To be anal, calling this method means the user will probably be wanting to add something. Whether they actually want to is not known until they call something doing that, so perhaps a wrapper interface to track that?
There was a problem hiding this comment.
hmmm, sounds like a lot of work... ;)
|
My 'wrapper interface' comments might not be totally in line with what the intent of this is. If setting readOnly=false is delayed, that might happen after the checks are done, which takes us back to the original problem :-) |
|
Build 2871 is now running using a merge of 15271dd |
|
Build 2871 outcome was FAILURE using a merge of 15271dd Build problems:Failed to build patch for build #2871 {build id=11931}, VCS root: "WildFly - Pull Request" {instance id=8, parent internal id=2, parent id=WF_WildFlyPullRequest, description: "https://github.com/wildfly/wildfly.git#refs/heads/master"}, due to error: Cannot find commit 1521e08 in repository (/store/teamcity/system/caches/git/git-270FFC1D.git, https://github.com/wildfly/wildfly.git#refs/heads/master) |
|
Build 2872 is now running using a merge of 15271dd |
|
Build 2875 is now running using a merge of 15271dd |
|
Good point re: the checks being delayed. So that's my excuse for being lazy! |
|
Build 2875 outcome was FAILURE using a merge of 15271dd Build problems:Failed tests detected Failed tests |
|
Build 2887 is now running using a merge of 03d626e |
|
Kabir, I added another commit that changed existing logic. WFLY-3076. |
|
Build 2887 outcome was SUCCESS using a merge of 03d626e |
|
@kabir can you +1 this one |
…ather than guessing from lock acquisition
…set domain-uuid in multi-process ops
…nce to register so we don't lose records
-- don't drop extension add ops -- don't log Stage.RUNTIME parallel boot ops -- include parallel boot ops in the same log record as all other ops controlled by the primary OperationContext
…om a management read
|
Build 3365 is now running using a merge of 322caff |
|
Rebased. Kabir has acked: [4/8/14, 12:04:12 PM] Brian Stansberry: I'm sure you are sick to death of PRs |
|
Build 3365 outcome was FAILURE using a merge of 322caff Build problems:Failed tests detected Failed tests |
|
unreleated failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of issues related to audit logging, plus https://issues.jboss.org/browse/WFLY-3020 which is unrelated but got noticed while I was doing the others.
Best to look at this commit by commit.