WFLY-285 Add support for clustered database timers #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 3906 is now running using a merge of 3cad79e |
|
Build 3906 outcome was FAILURE using a merge of 3cad79e Build problems:Failed tests detected Failed tests |
|
Oops, I forgot to include transformers in this patch |
|
needs also subsystem model version bump to 3.0 |
|
as for transformers goes, skip the 7.1.x ones, just add newer ones. |
|
Build 3912 is now running using a merge of 3ee164e |
|
Build 3912 outcome was FAILURE using a merge of 3ee164e Build problems:[Artifacts publishing failed] {build.status.text} |
|
Retest this please! |
|
Build 3936 is now running using a merge of 3ee164e |
|
Build 3936 outcome was SUCCESS using a merge of 3ee164e |
| .setFlags(AttributeAccess.Flag.RESTART_RESOURCE_SERVICES) | ||
| .setDefaultValue(new ModelNode(true)) | ||
| .build(); | ||
|
|
There was a problem hiding this comment.
It's too bad these require reload.
There was a problem hiding this comment.
That is just laziness on my part, it should be possible to make this work.
|
This needs some transformers. Looks good otherwise though. |
|
Why are the transformers required? The database data store was not part of EAP6, and already has reject transformers. |
|
Transformers are for WF 9 managing WF 8.x, unless the database data store doesn't occur in 8.x. |
|
we don't have baseline needed for 8.x transformers yet... |
|
@ctomc how do you mean? |
|
We've discussed elsewhere that skipping the transformers back to 8.x is ok. We have to transform to EAP 6 versions, but that's already covered by the existing transformers for the entire resource. This needs a rebase though. Stuart has been hoist by his own petard. And I'm very happy once again to have a chance to use that odd little expression. |
|
Build 4043 is now running using a merge of c7bab59 |
|
Build 4043 outcome was FAILURE using a merge of c7bab59 Build problems:Failed tests detected Failed tests |
bstansberry
added a commit
that referenced
this pull request
Jun 19, 2014
WFLY-285 Add support for clustered database timers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.