Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-3947: fixing calendar based timeout; also replacing problematic bui... #6788

Merged
merged 1 commit into from Oct 14, 2014

Conversation

emmartins
Copy link
Contributor

...ld test case with one matching original issue WFLY-1468

@wildfly-ci
Copy link

Linux with security manager Build 172 is now running using a merge of bea57f3

@wildfly-ci
Copy link

Windows Build 287 is now running using a merge of bea57f3

@wildfly-ci
Copy link

Linux Build 5141 is now running using a merge of bea57f3

@wildfly-ci
Copy link

Linux with security manager Build 172 outcome was SUCCESS using a merge of bea57f3
Summary: Tests passed: 793, ignored: 242 Build time: 0:06:40

@wildfly-ci
Copy link

Linux Build 5141 outcome was SUCCESS using a merge of bea57f3
Summary: Tests passed: 3088, ignored: 260 Build time: 0:56:02

@wildfly-ci
Copy link

Windows Build 287 outcome was SUCCESS using a merge of bea57f3
Summary: Tests passed: 3088, ignored: 260 Build time: 0:56:07

@emmartins
Copy link
Contributor Author

Some notes about the issues fixed by the PR:
Major:
* truncate of calendar does not keeps DST offset
* testsuite fix
Minor:
* truncate not needed if setting of time fields is done properly
* excessive calendar cloning
* excessive checks for no more timeouts
* first and next timeout computation logic duplicated

@stuartwdouglas
Copy link
Contributor

Has this been tested against the timers TCK?

@emmartins
Copy link
Contributor Author

yes, it passes the 141 tests in com/sun/ts/tests/ejb30/timer/schedule

…build test case with one matching original issue WFLY-1468
@wildfly-ci
Copy link

Linux with security manager Build 221 is now running using a merge of db5e9e0

@wildfly-ci
Copy link

Windows Build 336 is now running using a merge of db5e9e0

@wildfly-ci
Copy link

Linux Build 5212 is now running using a merge of db5e9e0

@wildfly-ci
Copy link

Linux with security manager Build 221 outcome was SUCCESS using a merge of db5e9e0
Summary: Tests passed: 792, ignored: 244 Build time: 0:06:19

@wildfly-ci
Copy link

Windows Build 336 outcome was SUCCESS using a merge of db5e9e0
Summary: Tests passed: 3021, ignored: 238, muted: 1 Build time: 0:54:41

@wildfly-ci
Copy link

Linux Build 5212 outcome was SUCCESS using a merge of db5e9e0
Summary: Tests passed: 3021, ignored: 238, muted: 1 Build time: 0:56:58

n1hility added a commit that referenced this pull request Oct 14, 2014
WFLY-3947: fixing calendar based timeout; also replacing problematic bui...
@n1hility n1hility merged commit 206ad18 into wildfly:master Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants