Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-30 SFSB containing injected DataSource fails to passivate/serialize #6925

Merged
merged 1 commit into from Nov 13, 2014
Merged

WFLY-30 SFSB containing injected DataSource fails to passivate/serialize #6925

merged 1 commit into from Nov 13, 2014

Conversation

maeste
Copy link
Contributor

@maeste maeste commented Nov 7, 2014

No description provided.

@wildfly-ci
Copy link

Linux Build 5432 is now running using a merge of 1be82b8

@wildfly-ci
Copy link

Linux with security manager Build 421 is now running using a merge of 1be82b8

@wildfly-ci
Copy link

Windows Build 535 is now running using a merge of 1be82b8

@wildfly-ci
Copy link

Linux with security manager Build 421 outcome was SUCCESS using a merge of 1be82b8
Summary: Tests passed: 797, ignored: 244 Build time: 0:06:21

@wildfly-ci
Copy link

Windows Build 535 outcome was FAILURE using a merge of 1be82b8
Summary: Tests failed: 2 (2 new), passed: 2996, ignored: 239 Build time: 0:50:43

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.management.cli.DataSourceTestCase.testXaDataSource: org.junit.ComparisonFailure: expected:<org.jboss.[jca.adapters.jdbc.Wrapper]DataSource> but was:<org.jboss.[as.connector.subsystems.datasources.WildFly]DataSource>
    at org.junit.Assert.assertEquals(Assert.java:115)
    at org.junit.Assert.assertEquals(Assert.java:144)

org.jboss.as.test.integration.management.cli.DataSourceTestCase.testDataSource: org.junit.ComparisonFailure: expected:<org.jboss.[jca.adapters.jdbc.Wrapper]DataSource> but was:<org.jboss.[as.connector.subsystems.datasources.WildFly]DataSource>
    at org.junit.Assert.assertEquals(Assert.java:115)
    at org.junit.Assert.assertEquals(Assert.java:144)

@wildfly-ci
Copy link

Linux Build 5432 outcome was FAILURE using a merge of 1be82b8
Summary: Tests failed: 2 (2 new), passed: 2996, ignored: 239 Build time: 0:53:49

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.management.cli.DataSourceTestCase.testXaDataSource: org.junit.ComparisonFailure: expected:<org.jboss.[jca.adapters.jdbc.Wrapper]DataSource> but was:<org.jboss.[as.connector.subsystems.datasources.WildFly]DataSource>
    at org.junit.Assert.assertEquals(Assert.java:115)
    at org.junit.Assert.assertEquals(Assert.java:144)

org.jboss.as.test.integration.management.cli.DataSourceTestCase.testDataSource: org.junit.ComparisonFailure: expected:<org.jboss.[jca.adapters.jdbc.Wrapper]DataSource> but was:<org.jboss.[as.connector.subsystems.datasources.WildFly]DataSource>
    at org.junit.Assert.assertEquals(Assert.java:115)
    at org.junit.Assert.assertEquals(Assert.java:144)

@wildfly-ci
Copy link

Linux with security manager Build 431 is now running using a merge of 604220a

@wildfly-ci
Copy link

Windows Build 544 is now running using a merge of 604220a

@wildfly-ci
Copy link

Linux Build 5442 is now running using a merge of 604220a

@wildfly-ci
Copy link

Linux with security manager Build 431 outcome was SUCCESS using a merge of 604220a
Summary: Tests passed: 797, ignored: 244 Build time: 0:06:23

@wildfly-ci
Copy link

Windows Build 544 outcome was SUCCESS using a merge of 7ddd1b4
Summary: Tests passed: 2998, ignored: 239 Build time: 0:51:37

@wildfly-ci
Copy link

Linux Build 5442 outcome was SUCCESS using a merge of 7ddd1b4
Summary: Tests passed: 2997, ignored: 239, muted: 1 Build time: 0:53:46

@wildfly-ci
Copy link

Linux Build 5443 is now running using a merge of 7ddd1b4

@wildfly-ci
Copy link

Linux with security manager Build 432 is now running using a merge of 7ddd1b4

@wildfly-ci
Copy link

Windows Build 546 is now running using a merge of 7ddd1b4

@wildfly-ci
Copy link

Linux with security manager Build 432 outcome was SUCCESS using a merge of 7ddd1b4
Summary: Tests passed: 797, ignored: 244 Build time: 0:06:26

@wildfly-ci
Copy link

Windows Build 546 outcome was SUCCESS using a merge of 7ddd1b4
Summary: Tests passed: 2998, ignored: 239 Build time: 0:50:45

@wildfly-ci
Copy link

Linux Build 5443 outcome was SUCCESS using a merge of 7ddd1b4
Summary: Tests passed: 2997, ignored: 239, muted: 1 Build time: 0:54:32

stuartwdouglas
stuartwdouglas reviewed Nov 11, 2014
View reviewed changes
...r/src/main/java/org/jboss/as/connector/subsystems/datasources/AbstractDataSourceService.java
@@ -134,10 +136,10 @@ public synchronized void start(StartContext startContext) throws StartException
if (deploymentMD.getCfs().length != 1) {
throw ConnectorLogger.ROOT_LOGGER.cannotStartDs();
}
sqlDataSource = (javax.sql.DataSource) deploymentMD.getCfs()[0];
sqlDataSource = new WildFlyDataSource((javax.sql.DataSource) deploymentMD.getCfs()[0], jndiName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance use code could rely on the datasource being assignable to some other class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not

@pferraro
Copy link
Contributor

Can you additionally validate this fix by enabling this test?
https://github.com/wildfly/wildfly/blob/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/cluster/ejb/stateful/StatefulFailoverTestCase.java#L159

stuartwdouglas added a commit that referenced this pull request Nov 12, 2014
@stuartwdouglas
Merge pull request #6925 from maeste/WFLY-30
1efc8fe
@wildfly-ci
Copy link

Linux with security manager Build 452 is now running using a merge of 0d11edd

@wildfly-ci
Copy link

Windows Build 566 is now running using a merge of 0d11edd

@wildfly-ci
Copy link

Linux Build 5463 is now running using a merge of 0d11edd

@wildfly-ci
Copy link

Linux with security manager Build 452 outcome was SUCCESS using a merge of 0d11edd
Summary: Tests passed: 797, ignored: 244 Build time: 0:06:37

@wildfly-ci
Copy link

Windows Build 566 outcome was SUCCESS using a merge of 0d11edd
Summary: Tests passed: 2998, ignored: 238, muted: 1 Build time: 0:51:00

@wildfly-ci
Copy link

Linux Build 5463 outcome was SUCCESS using a merge of 0d11edd
Summary: Tests passed: 2998, ignored: 238, muted: 1 Build time: 0:53:56

@maeste
Copy link
Contributor Author

maeste commented Nov 12, 2014

@pferraro done

stuartwdouglas added a commit that referenced this pull request Nov 13, 2014
@stuartwdouglas
Merge pull request #6925 from maeste/WFLY-30
3f60dda
stuartwdouglas added a commit that referenced this pull request Nov 13, 2014
@stuartwdouglas
Merge pull request #6925 from maeste/WFLY-30
7ba0637 
WFLY-30 SFSB containing injected DataSource fails to passivate/serialize
@stuartwdouglas stuartwdouglas merged commit 7ba0637 into wildfly:master Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@maeste @wildfly-ci @pferraro @stuartwdouglas