Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-4101 Make sure HttpServletRequest.logout() and Session.invalidate()... #6977

Merged
merged 1 commit into from Dec 6, 2014

Conversation

sguilhen
Copy link
Contributor

... trigger an AuthenticationManager logout

@wildfly-ci
Copy link

Linux Build 5513 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Linux with security manager Build 500 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Windows Build 622 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Linux with security manager Build 500 outcome was FAILURE using a merge of 333fa4a
Summary: Tests passed: 528, ignored: 235; exit code 1 (new) Build time: 0:04:01

Build problems:

Process exited with code 1

@wildfly-ci
Copy link

Linux Build 5513 outcome was FAILURE using a merge of 333fa4a
Summary: Tests passed: 592, ignored: 171; exit code 1 (new) Build time: 0:04:41

Build problems:

Process exited with code 1

@wildfly-ci
Copy link

Windows Build 622 outcome was FAILURE using a merge of 333fa4a
Summary: Tests passed: 592, ignored: 171; exit code 1 (new) Build time: 0:05:05

Build problems:

Process exited with code 1

@sguilhen
Copy link
Contributor Author

Looks like PicketBox has to be upgrade in WF core first. I'll re-open this PR once PB has been upgraded.

@sguilhen sguilhen closed this Nov 20, 2014
@kabir kabir added the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Nov 21, 2014
@kabir
Copy link
Contributor

kabir commented Nov 21, 2014

@sguilhen I added the core-upgrade-needed label so noone will look at this until there is an upgrade, so you can reopen it now if you like.

@sguilhen
Copy link
Contributor Author

@kabir Ok, reopening now. Thanks!

@sguilhen sguilhen reopened this Nov 21, 2014
@bstansberry
Copy link
Contributor

I kicked off a run testing this branch using a build of the latest WFCORE master:

http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=31610&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments

@sguilhen
Copy link
Contributor Author

sguilhen commented Dec 4, 2014

This vault error was fixed by @pskopek and AFAIK it has no relation with this specific commit. I'll take a look.

@bstansberry
Copy link
Contributor

@sguilhen: The vault error fix has already been committed. Probably you just need to rebase your branch, as that test job I ran does not rebase the specified branch onto WFLY master, it just uses the specified branch.

Not a big deal; we can always test this with the pull player job once WFCORE is upgraded. The pull player job will do a rebase.

@sguilhen
Copy link
Contributor Author

sguilhen commented Dec 5, 2014

Great! Thanks Brian.

@bstansberry
Copy link
Contributor

retest this please

@bstansberry bstansberry removed the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Dec 6, 2014
@wildfly-ci
Copy link

Linux with security manager Build 607 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Windows Build 732 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Linux Build 5621 is now running using a merge of 333fa4a

@wildfly-ci
Copy link

Linux with security manager Build 607 outcome was SUCCESS using a merge of 333fa4a
Summary: Tests passed: 797, ignored: 370 Build time: 0:05:39

@wildfly-ci
Copy link

Windows Build 732 outcome was SUCCESS using a merge of 333fa4a
Summary: Tests passed: 3017, ignored: 365 Build time: 0:51:16

@wildfly-ci
Copy link

Linux Build 5621 outcome was SUCCESS using a merge of 333fa4a
Summary: Tests passed: 3016, ignored: 365, muted: 1 Build time: 0:53:53

bstansberry added a commit that referenced this pull request Dec 6, 2014
WFLY-4101 Make sure HttpServletRequest.logout() and Session.invalidate()...
@bstansberry bstansberry merged commit 16b9339 into wildfly:master Dec 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants