Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-4214 Update the version of maven to 3.2.5 #7057

Merged
merged 1 commit into from Feb 6, 2015
Merged

WFLY-4214 Update the version of maven to 3.2.5 #7057

merged 1 commit into from Feb 6, 2015

Conversation

tomjenkinson
Copy link
Contributor

@wildfly-ci
Copy link

Windows Build 807 is now running using a merge of d8284d4

@wildfly-ci
Copy link

Linux Build 5696 is now running using a merge of d8284d4

@wildfly-ci
Copy link

Linux with security manager Build 683 is now running using a merge of d8284d4

@wildfly-ci
Copy link

Linux with security manager Build 683 outcome was SUCCESS using a merge of d8284d4
Summary: Tests passed: 787, ignored: 369 Build time: 0:05:30

@langfr
Copy link
Contributor

langfr commented Jan 2, 2015

Version number in download-maven.ps1 has to be changed too from 3.2.3 to 3.2.5.
As of #7058 a rebase is probably needed.

@tomjenkinson
Copy link
Contributor Author

thanks for the heads up - done the rebase and mod to other file now

@kabir
Copy link
Contributor

kabir commented Jan 2, 2015

@tomjenkinson FYI my merged #7058 also handles this, although it looks in a different location for 3.2.3 (driven by downstream where we need to be more conservative). The new location also seems to contain the latest 3.2.5, so this PR should be ok.

@wildfly-ci
Copy link

Windows Build 807 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2898, ignored: 364 Build time: 0:49:54

@wildfly-ci
Copy link

Linux Build 5696 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2897, ignored: 364, muted: 1 Build time: 0:52:20

@wildfly-ci
Copy link

Linux with security manager Build 684 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Linux Build 5697 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Windows Build 808 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Linux with security manager Build 684 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 787, ignored: 369 Build time: 0:05:06

@wildfly-ci
Copy link

Windows Build 808 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2899, ignored: 364 Build time: 0:48:38

@wildfly-ci
Copy link

Linux Build 5697 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2899, ignored: 364 Build time: 0:53:10

@ctomc
Copy link
Contributor

ctomc commented Jan 4, 2015

do not merge this yet! We need to verify that newer maven doesn't break anything.
In short hold for few more days.

@kabir kabir added the hold PR should not be merged for some reason. label Jan 6, 2015
@kabir
Copy link
Contributor

kabir commented Jan 6, 2015

Adding hold label in line with Tomaz's comments. @ctomc please let me know when you are happy

@ctomc
Copy link
Contributor

ctomc commented Jan 6, 2015

this is ok to be merged

@ctomc
Copy link
Contributor

ctomc commented Jan 7, 2015

A good thing would be to also have PR that upgrades maven in wildfly-core

@tomjenkinson
Copy link
Contributor Author

@ctomc I just tried to do that for maven-core but I can't find the place where maven is downloaded? I am using this repo: https://github.com/wildfly/wildfly-core/ I tried to search it for the download files but I can't see it nor can I find a build.sh to trigger any kind of maven verification.

@ctomc
Copy link
Contributor

ctomc commented Jan 8, 2015

@tomjenkinson you are right, i am thinking about too many branches and repos :(
There is no such script there (yet), it is in EAP repo but that is different story.
I have some branch somewhere to add it to core as well, I shouldn't quit coffee over the holidays...

aka @kabir please merge this.

@kabir
Copy link
Contributor

kabir commented Feb 6, 2015

Retest this please

@wildfly-ci
Copy link

Windows Build 955 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Linux Build 5846 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Linux with security manager Build 831 is now running using a merge of fedcc2f

@wildfly-ci
Copy link

Linux with security manager Build 831 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 839, ignored: 316 Build time: 0:05:07

@wildfly-ci
Copy link

Windows Build 955 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2922, ignored: 312 Build time: 0:47:18

@wildfly-ci
Copy link

Linux Build 5846 outcome was SUCCESS using a merge of fedcc2f
Summary: Tests passed: 2922, ignored: 312 Build time: 0:49:13

kabir added a commit that referenced this pull request Feb 6, 2015
WFLY-4214 Update the version of maven to 3.2.5
@kabir kabir merged commit eb34789 into wildfly:master Feb 6, 2015
@wolfc
Copy link
Contributor

wolfc commented Apr 1, 2015

Can someone clean up that 'hold' label?

@tomjenkinson tomjenkinson deleted the WFLY-4214 branch April 21, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold PR should not be merged for some reason.
Projects
None yet
6 participants