[WFLY-4335] ArquillianService incorrectly sets TCCL

[tdiesler]

https://issues.jboss.org/browse/WFLY-4335

[wildfly-ci]

Linux Build 117 is now running using a merge of dc21736

[ctomc]

home of wildfly arquillian container is now at https://github.com/wildfly/wildfly-arquillian we don't maintain 8.x stuff anymore.

[tdiesler]

In case there is another 8.2 release, I'd need this in. Currently, TCCL related issues are shadowed by how the ArquillianService works.

[wildfly-ci]

Linux Build 117 outcome was FAILURE using a merge of dc21736
Summary: Tests failed: 98 (98 new), passed: 5736, ignored: 80 Build time: 1:33:14

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.iiop.naming.IIOPNamingInContainerTestCase.testIIOPNamingInvocationWithDDOverride: java.lang.ClassCastException: null
    at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)

org.jboss.as.test.integration.ejb.iiop.naming.IIOPNamingInContainerTestCase.testStatefulIIOPNamingInvocation: java.lang.ClassCastException: null
    at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)

org.jboss.as.test.integration.ejb.iiop.naming.IIOPNamingInContainerTestCase.testIIOPNamingInvocation: java.lang.ClassCastException: null
    at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)

org.jboss.as.test.integration.ejb.mdb.objectmessage.unit.ObjectMessageTestCase.testObjectMessage: javax.jms.JMSException: org.jboss.as.test.integration.ejb.mdb.objectmessage.SimpleMessageInEarLibJar from [Module "org.hornetq:main" from local module loader @123a510 (finder: local module finder @129d183 (roots: /opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/../../../build/target/wildfly-8.2.1.Final-SNAPSHOT/modules,/opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/../../../build/target/wildfly-8.2.1.Final-SNAPSHOT/modules/system/layers/base,/opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/target/modules))]
    at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:213)
    at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:459)

org.jboss.as.test.integration.ejb.mdb.objectmessage.unit.ObjectMessageTestCase.testObjectMessageWithObjectArray: javax.jms.JMSException: org.jboss.as.test.integration.ejb.mdb.objectmessage.SimpleMessageInEarLibJar from [Module "org.hornetq:main" from local module loader @123a510 (finder: local module finder @129d183 (roots: /opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/../../../build/target/wildfly-8.2.1.Final-SNAPSHOT/modules,/opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/../../../build/target/wildfly-8.2.1.Final-SNAPSHOT/modules/system/layers/base,/opt/buildAgent/work/340a2b56aab3b1db/testsuite/integration/basic/target/modules))]
    at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:213)
    at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:459)

org.jboss.as.test.integration.ejb.security.AnnotationAuthorizationTestCase.testDenyAllOverride_User1: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)

org.jboss.as.test.integration.ejb.security.AnnotationAuthorizationTestCase.testRolesAllowedOverriden_User1: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)

org.jboss.as.test.integration.ejb.security.AnnotationAuthorizationTestCase.testRolesAllowedOverriden_User2: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)

org.jboss.as.test.integration.ejb.security.AnnotationAuthorizationTestCase.testPermitAllMethodWithArrayParams: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)

org.jboss.as.test.integration.ejb.security.AnnotationAuthorizationTestCase.testPermitAllOverride_User1: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)

org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_TwoBeans: javax.security.auth.login.LoginException: unable to find LoginModule class: org.jboss.security.ClientLoginModule
    at javax.security.auth.login.LoginContext.invoke(LoginContext.java:800)
    at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)


##### there are 88 more failed tests, see build details

[ctomc]

test failures are result of this change ^^

[stuartwdouglas]

The current behaviour is correct, and relied upon by our test suite.