[WFLY-4391] : When testing with WildFly Full, the WSTestCase is randomly unstable #7206
Conversation
|
Windows Build 1086 is now running using a merge of 5d21060 |
|
Linux Build 5973 is now running using a merge of 5d21060 |
|
Linux Build 5973 outcome was SUCCESS using a merge of 5d21060 |
|
Windows Build 1086 outcome was SUCCESS using a merge of 5d21060 |
| @@ -98,16 +107,17 @@ public void testManagementDescription() throws Exception { | |||
| operation.get(ModelDescriptionConstants.RECURSIVE).set(true); | |||
|
|
|||
| final ModelNode result = managementClient.getControllerClient().execute(operation); | |||
| Assert.assertEquals(ModelDescriptionConstants.SUCCESS, result.get(ModelDescriptionConstants.OUTCOME).asString()); | |||
|
|
|||
| assertThat(result.get(ModelDescriptionConstants.OUTCOME).asString(), is(ModelDescriptionConstants.SUCCESS)); | |||
There was a problem hiding this comment.
@ehsavoie all these replacements of Assert.assertEquals() with assertThat() seem pointless, and also make it hard to see exactly what has been changed. If we really 'must' do this replacement, please do so as a separate commit.
There was a problem hiding this comment.
Well it helps has you won't get a null assertion for the assertTrue but a more meaningfull message
As for assertEquals I changed those where we are testing for success on operation result, but I missed the line you are referencing
|
Windows Build 1088 is now running using a merge of be187c3 |
|
Linux Build 5975 is now running using a merge of be187c3 |
…mly unstable It seems that the test relies on WS metrics update which might occurs after the response has been received and processed by the client. Thus we may get a race.
…mly unstable Cleaning the test code to have more meaningfull assertion errors.
|
Linux Build 5975 outcome was SUCCESS using a merge of c5b1aa9 |
|
Windows Build 1088 outcome was SUCCESS using a merge of c5b1aa9 |
|
Linux Build 5976 is now running using a merge of c5b1aa9 |
|
Windows Build 1089 is now running using a merge of c5b1aa9 |
|
Linux Build 5976 outcome was SUCCESS using a merge of c5b1aa9 |
|
Windows Build 1089 outcome was SUCCESS using a merge of c5b1aa9 |
[WFLY-4391] : When testing with WildFly Full, the WSTestCase is randomly unstable
It seems that the test relies on WS metrics update which might occurs after the response has been received and processed by the client.
Thus we may get a race.
Jira: https://issues.jboss.org/browse/WFLY-4391