[WFLY-4554] cd into JBOSS_HOME instead of fancy escaping. #7386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand line ensure jconsole is executed from JBOSS_HOME, this way our custom classpath can be relative.
|
Windows Build 1437 is now running using a merge of b9dd151 |
|
Linux Build 6357 is now running using a merge of b9dd151 |
|
Linux with security manager Build 1285 is now running using a merge of b9dd151 |
|
Linux with security manager Build 1285 outcome was SUCCESS using a merge of b9dd151 |
|
Windows Build 1437 outcome was SUCCESS using a merge of b9dd151 |
|
Linux Build 6357 outcome was SUCCESS using a merge of b9dd151 |
n1hility
added a commit
that referenced
this pull request
Apr 24, 2015
[WFLY-4554] cd into JBOSS_HOME instead of fancy escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the jconsole script is the arguments get passed through the jconsole binary included with the JVM, there is not sufficient flexibility to escape the classpath so that it reaches the underlying Java process in the correct form.
On the other hand if we ensure we are in the troubled directory then the classpath can be relative.