Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-447] Debug message on mod_cluster MCMP handler creation. #7537

Merged
merged 1 commit into from Aug 4, 2015

Conversation

Karm
Copy link
Contributor

@Karm Karm commented May 28, 2015

  • added additional DEBUG message that aid QE

@wildfly-ci
Copy link

Can one of the admins verify this patch?

@kabir
Copy link
Contributor

kabir commented May 30, 2015

This is ok to test

@wildfly-ci
Copy link

Windows Build 1641 is now running using a merge of 2856058

@wildfly-ci
Copy link

Linux with security manager Build 1469 is now running using a merge of 2856058

@wildfly-ci
Copy link

Linux Build 6565 is now running using a merge of 2856058

@wildfly-ci
Copy link

Linux with security manager Build 1469 outcome was SUCCESS using a merge of 2856058
Summary: Tests passed: 825, ignored: 319 Build time: 0:05:35

@wildfly-ci
Copy link

Windows Build 1641 outcome was SUCCESS using a merge of 2856058
Summary: Tests passed: 2875, ignored: 374 Build time: 0:47:04

@wildfly-ci
Copy link

Linux Build 6565 outcome was SUCCESS using a merge of 2856058
Summary: Tests passed: 2875, ignored: 374 Build time: 0:47:11

@@ -312,4 +313,8 @@

@Message(id = 72, value = "Could not find configured external path %s")
DeploymentUnitProcessingException couldNotFindExternalPath(File path);

@LogMessage(level = DEBUG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug level messages do not need to be internationalised, so there is no need to put them on the logger.

@n1hility n1hility added the fixme label Jun 26, 2015
@kabir
Copy link
Contributor

kabir commented Jul 15, 2015

@Karm Can you fix?

@Karm
Copy link
Contributor Author

Karm commented Jul 15, 2015

Conflict resolved.

@wildfly-ci
Copy link

Linux Build 7040 is now running using a merge of 0c10c19

@wildfly-ci
Copy link

Windows Build 2095 is now running using a merge of 0c10c19

@wildfly-ci
Copy link

Linux with security manager Build 1916 is now running using a merge of 0c10c19

@wildfly-ci
Copy link

Linux with security manager Build 1916 outcome was SUCCESS using a merge of 0c10c19
Summary: Tests passed: 871, ignored: 280 Build time: 0:06:58

@wildfly-ci
Copy link

Windows Build 2095 outcome was FAILURE using a merge of 0c10c19
Summary: Tests failed: 1 (1 new), passed: 2943, ignored: 344 Build time: 0:49:19

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.mdb.containerstart.SendMessagesTestCase.testShutdown: <no details avaliable>

@wildfly-ci
Copy link

Linux Build 7040 outcome was SUCCESS using a merge of 0c10c19
Summary: Tests passed: 2942, ignored: 344, muted: 2 Build time: 0:50:15

@@ -326,4 +327,8 @@

@Message(id = 76, value = "Cannot remove resource of type %s")
IllegalArgumentException cannotRemoveResourceOfType(String type);

@LogMessage(level = DEBUG)
@Message(id = 77, value = "HttpHandler for mod_cluster MCMP created.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add messages below INFO to this file, as we have no need to localize debug messages.

@Karm
Copy link
Contributor Author

Karm commented Jul 24, 2015

Amended.

@wildfly-ci
Copy link

Linux with security manager Build 2045 is now running using a merge of f94c33c

@wildfly-ci
Copy link

Windows Build 2229 is now running using a merge of f94c33c

@wildfly-ci
Copy link

Linux Build 7173 is now running using a merge of f94c33c

@wildfly-ci
Copy link

Linux with security manager Build 2045 outcome was SUCCESS using a merge of f94c33c
Summary: Tests passed: 879, ignored: 282 Build time: 0:06:31

@wildfly-ci
Copy link

Linux Build 7173 outcome was SUCCESS using a merge of f94c33c
Summary: Tests passed: 2949, ignored: 354 Build time: 0:46:34

@wildfly-ci
Copy link

Windows Build 2229 outcome was SUCCESS using a merge of f94c33c
Summary: Tests passed: 2947, ignored: 355, muted: 1 Build time: 0:49:31

n1hility added a commit that referenced this pull request Aug 4, 2015
[UNDERTOW-447] Debug message on mod_cluster MCMP handler creation.
@n1hility n1hility merged commit 1c25581 into wildfly:master Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants