New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-447] Debug message on mod_cluster MCMP handler creation. #7537
Conversation
Karm
commented
May 28, 2015
- added additional DEBUG message that aid QE
Can one of the admins verify this patch? |
This is ok to test |
Windows Build 1641 is now running using a merge of 2856058 |
Linux with security manager Build 1469 is now running using a merge of 2856058 |
Linux Build 6565 is now running using a merge of 2856058 |
Linux with security manager Build 1469 outcome was SUCCESS using a merge of 2856058 |
Windows Build 1641 outcome was SUCCESS using a merge of 2856058 |
Linux Build 6565 outcome was SUCCESS using a merge of 2856058 |
@@ -312,4 +313,8 @@ | |||
|
|||
@Message(id = 72, value = "Could not find configured external path %s") | |||
DeploymentUnitProcessingException couldNotFindExternalPath(File path); | |||
|
|||
@LogMessage(level = DEBUG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug level messages do not need to be internationalised, so there is no need to put them on the logger.
@Karm Can you fix? |
2856058
to
0c10c19
Compare
Conflict resolved. |
Linux Build 7040 is now running using a merge of 0c10c19 |
Windows Build 2095 is now running using a merge of 0c10c19 |
Linux with security manager Build 1916 is now running using a merge of 0c10c19 |
Linux with security manager Build 1916 outcome was SUCCESS using a merge of 0c10c19 |
Windows Build 2095 outcome was FAILURE using a merge of 0c10c19 Build problems:Failed tests detected Failed tests
|
Linux Build 7040 outcome was SUCCESS using a merge of 0c10c19 |
@@ -326,4 +327,8 @@ | |||
|
|||
@Message(id = 76, value = "Cannot remove resource of type %s") | |||
IllegalArgumentException cannotRemoveResourceOfType(String type); | |||
|
|||
@LogMessage(level = DEBUG) | |||
@Message(id = 77, value = "HttpHandler for mod_cluster MCMP created.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add messages below INFO to this file, as we have no need to localize debug messages.
0c10c19
to
6b4f950
Compare
6b4f950
to
f94c33c
Compare
Amended. |
Linux with security manager Build 2045 is now running using a merge of f94c33c |
Windows Build 2229 is now running using a merge of f94c33c |
Linux Build 7173 is now running using a merge of f94c33c |
Linux with security manager Build 2045 outcome was SUCCESS using a merge of f94c33c |
Linux Build 7173 outcome was SUCCESS using a merge of f94c33c |
Windows Build 2229 outcome was SUCCESS using a merge of f94c33c |
[UNDERTOW-447] Debug message on mod_cluster MCMP handler creation.