New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-4922] Add smoke test for <deny-uncovered-http-methods/> tag #7748
Conversation
Linux with security manager Build 1882 is now running using a merge of 7ea925a |
Windows Build 2059 is now running using a merge of 7ea925a |
Linux Build 6998 is now running using a merge of 7ea925a |
Linux with security manager Build 1882 outcome was SUCCESS using a merge of 7ea925a |
Windows Build 2059 outcome was FAILURE using a merge of 7ea925a Build problems:Failed tests detected Failed tests
|
Linux Build 6998 outcome was SUCCESS using a merge of 7ea925a |
|
||
private HttpResponse getHttpResponse(HttpUriRequest request, String user, String password) throws IOException { | ||
String auth = user + ":" + password; | ||
byte[] encodedAuth = Base64.encodeBase64(auth.getBytes(Charset.forName("US-ASCII"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use JDK8's java.util.Base64 instead of external lib
Changes made. Could anyone review the code once again, please? |
Linux Build 7001 is now running using a merge of 9f23014 |
Windows Build 2061 is now running using a merge of 9f23014 |
Linux with security manager Build 1884 is now running using a merge of 9f23014 |
Linux with security manager Build 1884 outcome was SUCCESS using a merge of 9f23014 |
import java.io.IOException; | ||
import java.net.URL; | ||
import java.nio.charset.Charset; | ||
import java.util.Base64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't used anymore after auth was removed
Windows Build 2061 outcome was SUCCESS using a merge of 9f23014 |
Linux Build 7001 outcome was FAILURE using a merge of 9f23014 Build problems:Failed tests detected Failed tests
|
Linux with security manager Build 1885 is now running using a merge of 5c5e52a |
Linux Build 7005 is now running using a merge of 5c5e52a |
Windows Build 2063 is now running using a merge of 5c5e52a |
Linux with security manager Build 1885 outcome was SUCCESS using a merge of 5c5e52a |
Linux Build 7005 outcome was SUCCESS using a merge of 5c5e52a |
Windows Build 2063 outcome was SUCCESS using a merge of 5c5e52a |
[WFLY-4922] Add smoke test for <deny-uncovered-http-methods/> tag
With Java Servlet 3.1 specification comes possibility to use tag in web.xml file. This new feature should be tested by a basic smoke test.
https://issues.jboss.org/browse/WFLY-4922