Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-2137 Fix circular dependency between security subsystem, jacorb … #7946

Merged
merged 1 commit into from Aug 19, 2015

Conversation

stuartwdouglas
Copy link
Contributor

…and the transaction subsystem when JTS is enabled

@wildfly-ci
Copy link

Linux Build 7514 is now running using a merge of 795c329

@wildfly-ci
Copy link

Linux Build 7516 is now running using a merge of 795c329

@wildfly-ci
Copy link

Linux Build 7518 is now running using a merge of 795c329

@wildfly-ci
Copy link

Linux Build 7520 is now running using a merge of 795c329

@wildfly-ci
Copy link

Linux Build 7522 is now running using a merge of 795c329

@wildfly-ci
Copy link

Linux Build 7524 is now running using a merge of 720fe87

@wildfly-ci
Copy link

Linux Build 7524 outcome was SUCCESS using a merge of 720fe87
Summary: Tests passed: 3103, ignored: 369 Build time: 00:49:05

@bstansberry
Copy link
Contributor

I had similar transaction capability stuff in a branch (https://github.com/bstansberry/wildfly/commits/use-cap-req) but then never moved it forward once I realized the contract of these capabilities was really unclear. Other subsystems depend on a variety of different transactions stuff, so we need to work out what the API is. Some of the stuff people use is spec classes, while some is Arjuna details.

The other reason I didn't move forward is the way jts works violates what's described at http://lists.jboss.org/pipermail/wildfly-dev/2015-July/004269.html. I vaguely figured there that we'd add a child resource with the existing attribute retained for compatibility. (In a read the attribute would basically just indicate whether the child resource exists; in a write it would trigger add/remove of the child resource.)

Sounds like it's time to get this sorted.

@bstansberry
Copy link
Contributor

How about this?

  1. Drop the org.wildfly.transactions.jts part. Unless I missed it, it's not used in this PR.
  2. The rest is fine. You're not actually using any contract from the org.wildfly.transactions capability. You still directly use the subsystem's service name. So all this does is commit us to having a capability called "org.wildfly.transactions", and that is pretty safe. If we later create child capabilities for accessing services, or have "org.wildfly.transactions" itself provide something, that won't be an incompatible change.

This lets this specific problem be fixed ASAP without prematurely committing to much.

…and the transaction subsystem when JTS is enabled
@wildfly-ci
Copy link

Linux Build 7541 is now running using a merge of 9802d27

@wildfly-ci
Copy link

Linux Build 7541 outcome was SUCCESS using a merge of 9802d27
Summary: Tests passed: 3110, ignored: 365 Build time: 00:51:00

stuartwdouglas added a commit that referenced this pull request Aug 19, 2015
WFLY-2137 Fix circular dependency between security subsystem, jacorb …
@stuartwdouglas stuartwdouglas merged commit 1894b31 into wildfly:master Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants