[WFLY-5656]: No warning is shown when deploying web application with defined valves. #8407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,11 @@ public void deploy(DeploymentPhaseContext phaseContext) throws DeploymentUnitPro | |||
| warMetaData.setJBossWebMetaData(jBossWebMetaData); | |||
| // if the jboss-web.xml has a distinct-name configured, then attach the value to this | |||
| // deployment unit | |||
| if(jBossWebMetaData.getValves() != null) { | |||
| jBossWebMetaData.getValves().stream().forEach((valve) -> { | |||
There was a problem hiding this comment.
this is a real overkill for iterating a list :)
for (Valve valve: jBossWebMetaData.getValves()) would do just fine :)
There was a problem hiding this comment.
I'm a hipster baby ;)
There was a problem hiding this comment.
At the very least, note that Iterable has forEach as well, so you don't really have to create a Stream. Though I'd personally agree with Tomaz here.
There was a problem hiding this comment.
Benchmark: How Java 8 Lambdas and Streams Can Make Your Code 5 Times Slower: http://blog.takipi.com/benchmark-how-java-8-lambdas-and-streams-can-make-your-code-5-times-slower/
|
@stuartwdouglas Please approve, and ack the JBEAP if you think it should be acked. |
…defined valves. Adding warning traces if valves are defined.
|
Linux Build 8991 outcome was FAILURE using a merge of c2ea625 Failed tests |
|
retest this please |
stuartwdouglas
added
the
ready-for-merge
n1hility
added a commit
that referenced
this pull request
Jan 28, 2016
[WFLY-5656]: No warning is shown when deploying web application with defined valves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding warning traces if valves are defined.
Jira: https://issues.jboss.org/browse/WFLY-5656
https://issues.jboss.org/browse/JBEAP-1865