Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-5810] Move JndiPermission to its own package & cleanroom rewrite #8758

Merged
merged 1 commit into from Mar 14, 2016

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Mar 7, 2016

No description provided.

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 7, 2016

@bstansberry
Copy link
Contributor

Since master is targeting a 10.1 and this will get merged before any move to 11.x, should the old org.jboss.as.naming.JndiPermission be kept and deprecated? As a subclass, just keeping the constructors (mapping the old Action enum to the new stuff) and perhaps the 'public static void check(Name name, Action... actions)' method.

Hmm, the Serializable stuff would break though, and keeping that is too much trouble.

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 8, 2016

I worried a little about compatibility but I came to the conclusion that the whole reason I had to do this was because the class was unsupported in the first place. But if you think I should try and do something with compatibility, I could probably come up with something given a little time.

@bstansberry
Copy link
Contributor

Yeah, if anyone was using this class they had to have turned off or ignored the WARN logging. So now they'd have to tweak their security manager config, which is the kind of migration step the WARN was telling them about.

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Mar 9, 2016
n1hility added a commit that referenced this pull request Mar 14, 2016
[WFLY-5810] Move JndiPermission to its own package & cleanroom rewrite
@n1hility n1hility merged commit ee9fc18 into wildfly:master Mar 14, 2016
@dmlloyd dmlloyd deleted the wfly-5810 branch March 14, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Only for use by those with merge permissions!
Projects
None yet
3 participants