[WFLY-6792] Don't get the JobOperator service with a lock for read-on… #9051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,14 @@ | |||
| * @author <a href="mailto:jperkins@redhat.com">James R. Perkins</a> | |||
| */ | |||
| abstract class JobOperationUpdateStepHandler extends JobOperationStepHandler { | |||
There was a problem hiding this comment.
This class is not well named now. It's name led me to dig into this PR quite a bit because I was concerned an "update step handler" would not only be used for read-only ops. But it is, so that's good. :)
You should probably rename it JobOperationReadOnlyStepHandler since in the future someone else may get confused and extend it for a write op.
There was a problem hiding this comment.
Ping me before doing about this as I may merge this soon for 10.1, in which case a rename can come later. It's not necessary to fix the bug which is the first goal.
bstansberry
added
ready-for-merge
|
Only change since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly attributes.