Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-2011 Inconsistency of formatter and named-formatter in console… #9745

Closed
wants to merge 1 commit into from

Conversation

tedwon
Copy link

@tedwon tedwon commented Mar 6, 2017

… logging handler

wildfly/wildfly-core#2001

This PR is tightly related with wildfly/wildfly-core#2001 to get tests to pass in CI.
To pass tests, this PR's wildfly-core dependency should base on wildfly/wildfly-core#2001 branch (https://github.com/tedwon/wildfly-core/tree/WFCORE-2011).
It requires merging wildfly/wildfly-core#2001 first before merging this PR.

… logging handler

wildfly/wildfly-core#2001

This PR is tightly related with wildfly/wildfly-core#2001 to get tests to pass in CI.
To pass tests, this PR's wildfly-core dependency should base on wildfly/wildfly-core#2001 branch (https://github.com/tedwon/wildfly-core/tree/WFCORE-2011).
It requires merging wildfly/wildfly-core#2001 first before merging this PR.
@wildfly-ci
Copy link

Can one of the admins verify this patch?

@jamezp
Copy link
Member

jamezp commented Mar 6, 2017

this is okay to test

@kabir
Copy link
Contributor

kabir commented Mar 14, 2017

Needs a downstream PR to to get considered atm

@JiriOndrusek
Copy link
Contributor

In a case that difference mentioned in wildfly/wildfly-core#2001 will be added to that PR, there will be probably no need to change TransactionSubsystemTestCase.java

@kabir
Copy link
Contributor

kabir commented Feb 7, 2018

@tedwon As this pull request has been held up for a long time, I am closing it to get the pull request queue under control again. Since this is very old now, it will be a very long time until this one will be addressed. Also, I don't have much time to spend on this to evaluate on a case by case basis.

If this is something important to you or the project please feel free to recreate the pull request. That way it will come on top of the pile again, and be looked at again sooner.

If it is a new feature, please follow the new process for features. Ping @kabir or @Jamez if you are unsure what this means, and we can help. Please do that before opening the pull request though.

Sorry for any inconvenience!

@kabir kabir closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants