[WFLY-8628] [WFLY-8630] Fix the client passwords specified in both SwitchIdentityTestCase#testClientLoginModule tests and unignore these tests #9964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itchIdentityTestCase#testClientLoginModule tests and unignore these tests
dmlloyd
approved these changes
Apr 24, 2017
|
Sweet! I gambled going ahead with the 3.0.0.Beta16 core release with 4 failures, but we're already down to just 2! Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SwitchIdentityTestCase classes were recently updated to specify the client passwords that should be used by these tests. Before this change, it turns out that these tests were only passing because the JBOSS-LOCAL-USER mechanism was erroneously getting used instead of the DIGEST-MD5 mechanism. These tests are currently failing because the client passwords should be clear passwords instead of the hashed passwords.
https://issues.jboss.org/browse/WFLY-8628
https://issues.jboss.org/browse/WFLY-8630