-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to randomize enemy attacks and add readme #43
Conversation
✅ Deploy Preview for gallant-brown-05664f ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FFMQRLib/Enemies.cs
Outdated
@@ -163,11 +191,64 @@ public void Write(FFMQRom rom) | |||
rom.PutInBank(RomOffsets.EnemiesStatsBank, RomOffsets.EnemiesStatsAddress + (_Id * RomOffsets.EnemiesStatsLength), _rawBytes); | |||
} | |||
} | |||
public class EnemiesAttacks | |||
public class EnemyAttack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnemyScript might be more appropriate a name and would avoid confusion with the actual attacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed it to EnemyAttackLink(s), from the SQL world, describing a many-to-many relationship. Let me know what you think.
|
||
// Enemies' Stats | ||
public const int EnemiesStatsAddress = 0xC275; // Bank 02 | ||
public const int EnemiesStatsBank = 0x02; | ||
public const int EnemiesStatsQty = 0x53; | ||
public const int EnemiesStatsLength = 0x0e; | ||
|
||
// Enemies' Attacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this info into the class for easier reference (again, in insight, this info shouldn't be referenced by anything else, there's no need to expose it globally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the same coding style as used in other tables. If we want to change this, I would prefer doing this in a separate PR that does it project-wide.
fdbb79a
to
abf46ec
Compare
Seems stable after some testing, but might end up with one or two issues.
Seems stable after some testing, but might end up with one or two issues.