Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to randomize enemy attacks and add readme #43

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

Oipo
Copy link
Contributor

@Oipo Oipo commented Sep 9, 2022

Seems stable after some testing, but might end up with one or two issues.

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for gallant-brown-05664f ready!

Name Link
🔨 Latest commit 7940735
🔍 Latest deploy log https://app.netlify.com/sites/gallant-brown-05664f/deploys/631ddb51cf8bb80008003131
😎 Deploy Preview https://deploy-preview-43--gallant-brown-05664f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

FFMQRLib/Enemies.cs Outdated Show resolved Hide resolved
@@ -163,11 +191,64 @@ public void Write(FFMQRom rom)
rom.PutInBank(RomOffsets.EnemiesStatsBank, RomOffsets.EnemiesStatsAddress + (_Id * RomOffsets.EnemiesStatsLength), _rawBytes);
}
}
public class EnemiesAttacks
public class EnemyAttack
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnemyScript might be more appropriate a name and would avoid confusion with the actual attacks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it to EnemyAttackLink(s), from the SQL world, describing a many-to-many relationship. Let me know what you think.

FFMQRLib/Enemies.cs Outdated Show resolved Hide resolved

// Enemies' Stats
public const int EnemiesStatsAddress = 0xC275; // Bank 02
public const int EnemiesStatsBank = 0x02;
public const int EnemiesStatsQty = 0x53;
public const int EnemiesStatsLength = 0x0e;

// Enemies' Attacks
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this info into the class for easier reference (again, in insight, this info shouldn't be referenced by anything else, there's no need to expose it globally)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the same coding style as used in other tables. If we want to change this, I would prefer doing this in a separate PR that does it project-wide.

README.md Outdated Show resolved Hide resolved
FFMQRLib/Enemies.cs Outdated Show resolved Hide resolved
Seems stable after some testing, but might end up with one or two issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants