-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows cleanup: use secrets directly and dedupe test runs #145
Conversation
Now that CI has run here, we can see this in action:
So if I may be so bold ... |
I assume windows tests are failing because, as @atmorling mentioned at standup today, windows throws an error if EarthEngine credentials are not available, and we haven't yet recreated the test secrets as Repository Secrets. Once that's done, we can re-run tests to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - looks good.
@ericgitonga Would you have the original credentials set up in the Testing environment?
I have the creds I use on my local... For original creds, let me check on those. |
Thanks @ericgitonga ! |
@ericgitonga since #129 exists I guess the original creds were linked to someone's personal account. |
Yes indeed. Peter Kulits was the one who first came up with this, so we'd have to check with him for those. I've asked him and await his response. |
I have emailed to you both (on your earthranger accounts) the info from Peter. |
I've gone ahead and added the credentials to the repo secrets |
I've also updated the branch protection rules as they required a successful 'deployment' which is no longer relevant with this change |
Closes #143
This PR cleans up our CI testing / workflows developer experience in two ways:
Testing
deployment environment for? #143).Note: To get CI to work with this new secrets configuration, we will need to recreate the Testing Deployment Secrets as Repository Secrets, on https://github.com/wildlife-dynamics/ecoscope/settings/secrets/actions, here:
For probably good security reasons, we can't move existing secrets, so they will need to be re-added by someone who has access to the original secrets.