Improve get_edges; an iterator example, Fixes #26 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdumas
reviewed
Dec 28, 2021
| friend bool operator==(const Tuple& a, const Tuple& t) | ||
| { | ||
| return ( | ||
| std::tie( |
There was a problem hiding this comment.
You can use std::make_tuple instead of tie.
| class IterableMesh : public TetMesh | ||
| { | ||
| public: | ||
| struct EdgeIterator |
There was a problem hiding this comment.
I find it easier to write a foreach_edges function with a custom callback function rather than have to implement your own iterator type.
There was a problem hiding this comment.
In fact, this PR is meant to initiate a discussion on how we want to proceed with the interface. That's why I am prototyping in a testing section.
jiangzhongshi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.