Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request -Add Renogy BT1 support #125

Closed
screech24 opened this issue May 27, 2023 · 3 comments
Closed

Feature Request -Add Renogy BT1 support #125

screech24 opened this issue May 27, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@screech24
Copy link

screech24 commented May 27, 2023

It would be incredible if you could somehow add support for Renogy BT1 Bluetooth modules. See this github link which someone has created a python script to read data from these modules.
https://github.com/cyrils/renogy-bt1

@retrodaredevil
Copy link
Member

This was talked about a little here: #44. I'm less opposed to trying this out now that others have had success, but this is something that I won't be testing or adding support for.

I'm not opposed to having someone else contribute to make the feature work, but I expect that Java support for Bluetooth is not as good as Python support for Bluetooth. Should someone decide to contribute to this there would have to be a lot of requirements to make this feature useable:

  • Configuration should require a Bluetooth ID (or whatever the Bluetooth terminology is for a device's ID)
    • (Eventually) Configuration should also be as similar to current configuration options, meaning it should require the specification of a Modbus ID
  • solarthing check command needs to be able to scan for Bluetooth devices so people can figure out their device's Bluetooth ID

Sorry that this feature is not a priority for me right now. I do think that implementing this feature would get more people to use SolarThing.

@retrodaredevil retrodaredevil added enhancement New feature or request help wanted Extra attention is needed labels May 27, 2023
@screech24
Copy link
Author

screech24 commented May 27, 2023 via email

@retrodaredevil
Copy link
Member

Going to close this issue for now. Anyone is welcome to reopen this in the future if anyone has anything else to add or would like to contribute to this feature.

@retrodaredevil retrodaredevil closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants