Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve codebase #42

Closed
vilhelmprytz opened this issue Feb 17, 2020 · 0 comments · Fixed by #45
Closed

Improve codebase #42

vilhelmprytz opened this issue Feb 17, 2020 · 0 comments · Fixed by #45
Assignees
@vilhelmprytz
Labels
enhancement New feature or request

Comments

@vilhelmprytz
Copy link
Member

vilhelmprytz commented Feb 17, 2020 •
edited
Loading

A lot of the code is currently not consistent. Before #34 is implemented, I think a lot of the methods (i.e. servers.py, server_config.py, config_parser.py and images.py) should be rewritten to be more consistent and that the different method functions should be split into smaller modules so that the application as a whole can be imported as an API (and separate the CLI from the Wilfred API).

With this implemented, a more general and predictable extension system could be implemented. I also propose the CLI should be completely separated from the core API itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilhelmprytz vilhelmprytz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor codebase wilfred-dev/wilfred
1 participant
@vilhelmprytz