Refactor codebase #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 45b4caf into 6e035ac - view on LGTM.com new alerts:
|
write one decorator to rule check whether the Wilfred config is present or not. Used on all click-commands where it is required for the configuration to be present
|
This pull request introduces 1 alert when merging 14b3dac into c467222 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 80dd6cd into c467222 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ec70337 into 7d32f73 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c802110 into d3b2eab - view on LGTM.com new alerts:
|
move wilfred/parser to wilfred/api/parser (update imports) move wilfred/server_config to wilfred/api/server_config improve CLI exception handling (add spinner.fail() before ui_exception is called on Halo spinners)
server_config is in wilfred.api.server_config and not wilfred.server_config
server_config is now refactored raises Wilfred exceptions where it makes sense to and custom UnsupportedFiletype exception catch exceptions as ui_exception() in CLI
tests used to create a pseudo configuration dict, to avoid issues this has now been replaced by the actual Config method (from wilfred.api.config_parser)
MikaelPrytz
approved these changes
Apr 10, 2020
|
Great code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split codebase into Wilfred CLI and Wilfred API more clearly. Will make it easier to develop an extension system. This is a refactor, no changes to the end-user are planned.
Fixes #42