Sanitize API #76
Draft
Sanitize API #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wilfred.errors is now wilfred.api.errors, wilfred.database is now wilfred.api.database
* introduced wilfred.api.servers "create" function, ability to create a new server without ever having to interact with the database * introduced wilfred.api.servers "query" function, get a db object of server via API and not via database
* accidentally imported "environ" from os in previous commit, removed this * added ability to override random_string() as id when creating a new server
* tests/test_server.py: now uses wilfred.api.servers.create to create server over adding db object to database directly
* forgot variable name, name=name.lower() and not just the argument name.lower()
|
This is quite out-of-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wilfred.errorsis nowwilfred.api.errors,wilfred.databaseis nowwilfred.api.databaseTODO:
server.createwhich currently requires the CLI to manually create a database object).Fixes #60