Update parameters.cljs example to quote query before being passed to parser #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souenzzo
suggested changes
Aug 5, 2020
|
|
||
| *Note:* If you are calling the parser directly, be sure to quote your query when using parameters like so: | ||
| ```clojure | ||
| (parser {} (parser {} '[(::instruments {:sort :instrument/brand})]) |
There was a problem hiding this comment.
ahh sorry about that! not sure what happened there..
docs/index.adoc
Outdated
| @@ -673,6 +673,21 @@ Try it out: | |||
| <div class="space"></div> | |||
| ++++ | |||
|
|
|||
| *Note:* If you are calling the parser directly, be sure to quote your query when using parameters like so: | |||
| ```clojure | |||
| (parser {} (parser {} '[(::instruments {:sort :instrument/brand})]) | |||
|
Thanks for the comments, updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will evaluate the sub-expression
[(::instruments {:sort :instrument/brand})]before it reaches the parser function. Thus, if we want to specify a parameter, we have to make sure it's quoted.I also added a Note about this in the docs, but I wasn't sure if this was wanted. Happy to remove if it's not warranted.