Tests and documentation for BomPlugin #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsona
force-pushed
the
gradle-build
branch
4 times, most recently
from
d12d244
to
5819ed3
Compare
wilkinsona
force-pushed
the
gradle-build
branch
5 times, most recently
from
c9b55e9
to
48c70ae
Compare
wilkinsona
force-pushed
the
gradle-build
branch
2 times, most recently
from
08a8efb
to
e2ad30c
Compare
wilkinsona
force-pushed
the
gradle-build
branch
2 times, most recently
from
f953f91
to
a4621da
Compare
wilkinsona
force-pushed
the
gradle-build
branch
3 times, most recently
from
f835217
to
8001073
Compare
wilkinsona
force-pushed
the
gradle-build
branch
5 times, most recently
from
0f1f454
to
3f46499
Compare
wilkinsona
force-pushed
the
gradle-build
branch
from
ad95eeb
to
cac42f1
Compare
wilkinsona
force-pushed
the
gradle-build
branch
25 times, most recently
from
f113c31
to
034e6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a couple bug fixes, tests, and docs to the BomPlugin under
buildSrc/.testResolvesDependencyVersionsUsingProperties()is failing for a reason I haven't figured out yet, because I imagine this is working in practice. Perhaps the version injection happens after thegeneratePomFileForBomPublicationtask as part ofpublish.