Postdecorators/movies2 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding RenderingDef_ID option for forcing a specific one to be loaded and Do_Link which defaults to the default behaviour of creating an OriginalFile holding the movie, linking it to a FileAnnotation and the latter to the Image used to create the movie. If Do_Link is False the OriginalFile is returned unlinked instead.
No options are parsed yet.
Watermark changes: No longer converting the passed image, moved to bottom left corner from centered
|
There was some question of empty movies being created at this morning's standup, but several bugs have been fixed so this is an overall win. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new attempt at getting the Make_Movie changes into the mainline. It has only commits that relate to the make movie script and its usage and has been tested in the journal workflow as well as using the cli interface.
Includes Sebastien's PR cherry picked into this branch.
If the script arg "RenderingDef_ID' is used then there's a dependency on cneves@a548ae1 which will be target of a separate PR.