Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open links from terminal #148

Closed
maharjanaman opened this issue Nov 4, 2019 · 26 comments
Closed

Unable to open links from terminal #148

maharjanaman opened this issue Nov 4, 2019 · 26 comments

Comments

@maharjanaman
Copy link

I use iTerm and I cannot open links from terminal.

@maharjanaman maharjanaman changed the title Unable to links from terminal Unable to open links from terminal Nov 4, 2019
@will-stone
Copy link
Owner

Do you mean command-click? Works for me in iTerm:

screencast 2019-11-04 8 am-35-33

@maharjanaman
Copy link
Author

Can you try that in fullscreen mode?

@will-stone
Copy link
Owner

Yep, still working fine 😕

@maharjanaman
Copy link
Author

If it helps, I'm using iTerm build 3.3.6 and on macOS Catalina 10.15.1
Works perfectly when not on fullscreen. I entered iTerm fullscreen mode using command-return.

@will-stone
Copy link
Owner

I have same setup. What happens exactly when you command click a link in full screen? Also, which version of Browserosaurus are you using? Click the menubar icon to find the version number.

@maharjanaman
Copy link
Author

maharjanaman commented Nov 4, 2019

I think I've latest one i.e. 8.0.1. I found something new here. So when I try to open link on fullscreen mode and switch to Desktop 1, there I see browserosaurus options.
Sorry, I couldn't create gif and upload it but here is the zip video
Screen Recording 2019-11-04 at 15.18.43.mov.zip

@will-stone
Copy link
Owner

Ah, what's your setting for "displays have separate spaces"?

image

@maharjanaman
Copy link
Author

Yep, unchecking that option seems to be working now.

@tudoramariei
Copy link

tudoramariei commented Nov 4, 2019

Same problem seems to happen on other apps as well if they're full screen

Screen recording of trying to open a link from Slack:
https://drive.google.com/open?id=14J3Nlo_Zt_aRZs94xvZttJkZOkUXIMAy

the transition to the white screen is me managing to open Chrome after selecting the text and hitting space

  • OS: macOS 10.15.1 (Catalina, last update)
  • Version 8.0.1

Also, I'd rather I didn't have to give up on Displays have separate Spaces since that would pretty much break my workflow

@will-stone
Copy link
Owner

Thanks @tudoramariei. I totally agree about not having to change that option. This may be a limitation of Electron, however I'll mark this as a bug and hopefully a fix is possible.

@will-stone
Copy link
Owner

Looks like this isn't possible yet without a plugin, that I'm not sure I'm comfortable using. Hopefully it'll make into Electron as a first-class API.

electron/electron#4939

@GaldanM
Copy link

GaldanM commented Nov 7, 2019

Hey @will-stone,

Just checked this issue coming from #136, even when unchecking Displays have separate Spaces, same behaviour happen 😕

I hope Electron will fix that soon !

@will-stone
Copy link
Owner

@GaldanM I'm getting it now too. I actually updated B to use the latest Electron, the other day. We were using v5 and now it's on v7. I'm not really sure it's a fix per se that's required, more that it needs a new feature added to allow windows above all others, à la Alfred or Spotlight.

@PierrickGT
Copy link

I've found a way to make it work.
If I quit Browserosaurus and then open a link in a fullscreen app, it will launch Browserosaurus to open this link and then it will display and work correctly. Seems to be the most efficient way to make it work for fullscreen apps.

@will-stone
Copy link
Owner

@PierrickGT Do you need to quit B before each time a link is opened in a fullscreen app?

Side rant: I sometimes feel like I'm the only person who doesn't use fullscreen mode; I just never click that green button. Yes, I make apps the size of my screen (I use an app called Magnet which maps ctrl-alt-enter to maximise) but never full screen. I feel like all that moving between screens gets a bit too much; I don't want my windows to be in motion when I change between them, when cmd-tab is instant.

@PierrickGT
Copy link

@will-stone no, it works as normal once a link is opened in a fullscreen app.

@tudoramariei
Copy link

tudoramariei commented Nov 20, 2019

Something that seems to have worked (or who knows) is to open the app non-fullscreen and then full-screen it
I tried this with Slack and what happened is...

  1. I quit B as @PierrickGT mentioned, then clicked a link in fullscreen Slack and B appeared
  2. clicked another time and B didn't appear (maybe a glitch in the matrix)
  3. after click 3, B was already appearing consistently with Slack in fullscreen mode and without quitting it anymore

Side rant reply: In my case, I just keep some applications on fullscreen (i.e. Slack, VS Code) since I don't have multiple windows or other similar features here. I use mission control quite a lot and it helps to see the name of the app instead of the generic Desktop #
P.S. Magnet rocks 🤘

@will-stone
Copy link
Owner

I have a feeling that the fix for #166 may have also fixed this. Maybe. 🤞

Could someone please check once you receive the 9.0.1 update?

@tudoramariei
Copy link

Just tested the new version and the app seems to be working fine now 🙌 🎉 🎊
Would like to see at least one more person confirming this since the behaviour was rather inconsistent since my last message 😅

@maharjanaman
Copy link
Author

I find it working as well. Sometimes I've to quit the app and start it again but its working fine now.

@will-stone
Copy link
Owner

Nice! Well, let's close this out and if anyone notices it not working again, feel free to reopen.

@maharjanaman
Copy link
Author

@will-stone I'm seeing similar issue with latest version i.e. 9.2.0. Thanks
Kapture 2020-02-19 at 9 53 16

@will-stone
Copy link
Owner

@maharjanaman I've just been through the app to familiarise myself with the issue and it seems like a lot of restarting of B and other apps/OS fixed the problem. You tried all of that?

@maharjanaman
Copy link
Author

@will-stone no luck for me. Tried restarting the os and B app multiple times.

@will-stone
Copy link
Owner

I can confirm it too. Please trawl Electron's repo for a fix as it appears they are the cause.

@will-stone
Copy link
Owner

Closing this out in favour of #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants