Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch browser logos using npm? #97

Closed
alrra opened this issue May 23, 2019 · 4 comments · Fixed by #105
Closed

Fetch browser logos using npm? #97

alrra opened this issue May 23, 2019 · 4 comments · Fixed by #105
Labels

Comments

@alrra
Copy link

alrra commented May 23, 2019

The browser logos are available on npm. They are usually keep up to date and highly optimized (e.g. see the changelogs for Firefox, Chrome, etc.).

@alrra alrra changed the title Fetch browser logos via npm? Fetch browser logos using npm? May 23, 2019
@will-stone
Copy link
Owner

Indeed. That's where I get them from. I don't really want this to be dynamic, as I'd rather B comes packaged with everything it needs to run without having to make calls to the internet; the logos do not change regularly enough for this to be an issue. However, if we find a way to scan for all browsers and there's no longer a whitelist, then this could be handy.

@alrra
Copy link
Author

alrra commented Jun 1, 2019

@will-stone Thank you for your reply!


I don't really want this to be dynamic, as I'd rather B comes packaged with everything it needs to run without having to make calls to the internet;

I wasn't suggesting you fetch them dynamically. Have them as devDependencies, fetch them at build time, and copy them into your build product. Or, if you want to be even safer, have something such as a npm script that just updates the local (committed) images.

the logos do not change regularly enough for this to be an issue.

They are constantly being optimized.

@will-stone
Copy link
Owner

Ah, I hadn't realised it was your repo 😆 Well, firstly, thanks for that project it has certainly made getting the logos together much easier. I will look into adding the logos as a devDep. Cheers.

@will-stone will-stone reopened this Jun 2, 2019
@will-stone
Copy link
Owner

I'm in the process of upgrading the dev environment to use Electron Forge v6, this brings support for webpack and allows me to more easily import the browser logos using your npm package. I hope to have that finished soon, and I've already got the logo import working, so this will come with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants