registering UUID Arrays #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Oct 23, 2021
| @@ -173,4 +173,5 @@ module PG | |||
| array_type String, 1009 | |||
| array_type Numeric, 1231 | |||
| array_type Time, [1115, 1182] | |||
| array_type UUID, 2951 | |||
There was a problem hiding this comment.
Verified this from a table that had a uuid[] type using SELECT * FROM pg_attribute WHERE attrelid = 'buckets'::regclass;
There was a problem hiding this comment.
Thanks. You could also get it with
will=# select pg_typeof(array[gen_random_uuid()]);
pg_typeof
-----------
uuid[]
(1 row)
Time: 0.367 ms
will=# select pg_typeof(array[gen_random_uuid()])::oid;
pg_typeof
-----------
2951
(1 row)
Time: 0.21or checking out this file https://github.com/postgres/postgres/blob/14472442861ca95cc9158518acdedf740c4bff55/src/include/catalog/pg_type.dat#L402
The latter is good to make sure that some of these less-oftenly-seen types have stable OIDs, vs ones that may come from extensions which can change, even if that extension comes with postgres. Still need to do something about those eventually.
There was a problem hiding this comment.
oh nice! That's good to know. Thanks 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when getting the value of a
Array(UUID)from postgres giving youBytesinstead ofArray(PG::UUIDArray).It seems when I added #225 I forgot this extra bit 😬 oops!