Make BIO_METHOD initialization for OpenSSL 1.1 thread-safe #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation attempts to select one of the following implementations, in the decreasing order of preference: - On C++11 compilers, use function-local statics initialization, which is thread-safe. - On POSIX systems, use pthreads as it supports static initialization. - On all other systems, use PMutex from PTLib. The last option is, strictly speaking, a regression from OpenSSL 1.0, which allows to statically initialize the BIO_METHOD structure. It should not be significant, though, as users are unlikely to work with PSSLChannel in global constructors and destructors.
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation attempts to select one of the following implementations,
in the decreasing order of preference:
thread-safe.
The last option is, strictly speaking, a regression from OpenSSL 1.0, which
allows to statically initialize the BIO_METHOD structure. It should not be
significant, though, as users are unlikely to work with PSSLChannel in global
constructors and destructors.
Only tested for compilation on Linux with OpenSSL 1.0 and 1.1.