Add missing macros so that autoconf can be regenerated #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the autoconf script cannot be regenerated due to some missing macros.
configure.ac:17: error: possibly undefined macro: dnl
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:187: error: possibly undefined macro: AC_DEFINE
aclocal generates the minimal macros necessary to resolve the issue.
|
In what situation do you get the mentioned error message ? Also, your pull request seems incomplete. You seem to have made other changes to configure.ac, eg. renaming OPENSSL and SDL to lowercase (which I don't really like). |
When you try to regenerate the autoconf script. I didn't make any other changes. That is the proper auto-generated form with the macros being used as is. What else is necessary for the PR? |
|
Running "autoconf" to regenerate configure works fine when I try it. I don't see the issue, yet. |
|
Added aclocal.m4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the autoconf script cannot be regenerated due to some missing macros.
configure.ac:17: error: possibly undefined macro: dnl
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:187: error: possibly undefined macro: AC_DEFINE
aclocal generates the minimal macros necessary to resolve the issue.