Update SSL params to disable unsafe features and enable TLS version negotiation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egotiation. This patch does the following: - Disable TLS compression as it is vulnerable to CRIME. - Disable SSLv2 and SSLv3. The latter is disabled unless specifically requested on SSL context creation. - For all SSL/TLS modes enable TLS version negotiation. This is especially useful for TLS as the only TLS version the library currently supports is TLS v1.0. Negotiation allows to use newer versions, as supported by OpenSSL.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does the following:
on SSL context creation.
useful for TLS as the only TLS version the library currently supports is
TLS v1.0. Negotiation allows to use newer versions, as supported by OpenSSL.
I realize that this patch changes the meaning of some of the PSSLContext::Method enum values, so this PR is mostly an RFC. If the change is not acceptable in the current form, any directions on how to proceed would be appreciated.