Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions. #34

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

slig
Copy link
Contributor

@slig slig commented Sep 13, 2018

Following on #33, here's the PR.

There're a couple of things I'm not 100% sure, though.

I don't think that the types Square, Piece, Position and CustomPieces have to be exported, so I didn't export them. Also the roughSquare receives a squareElement which I believe the appropriate type is SVGElement.

Thank you for your time on this!

@codecov-io
Copy link

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files          10       10           
  Lines         272      272           
  Branches       62       62           
=======================================
  Hits          171      171           
  Misses         80       80           
  Partials       21       21

@willb335
Copy link
Owner

I don't think that the types Square, Piece, Position and CustomPieces have to be exported, so I didn't export them.

That sounds fine if somebody needs them exported I can look into it.

Could you make a new pull request running npm run commit and then just follow the prompts and add it as a 'doc' change? This helps to integrate the new commits into versioning.

I'm afraid if I amend the commit myself then it won't recognize you as a contributor.

@willb335
Copy link
Owner

on second thought, this won't affect versioning since it is not a feature change, I'll merge this in. Thanks!

@willb335 willb335 merged commit 1a245fa into willb335:master Sep 13, 2018
@willb335 willb335 mentioned this pull request Sep 13, 2018
@slig
Copy link
Contributor Author

slig commented Sep 13, 2018

Thank you very much!

@willb335
Copy link
Owner

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants