Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learned Interiors functionality for numerical calibrators #9

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Learned Interiors functionality for numerical calibrators #9

merged 4 commits into from
Dec 6, 2023

Conversation

brianpark0126
Copy link
Collaborator

Closes #8

willbakst
willbakst requested changes Nov 30, 2023
View reviewed changes
Copy link
Owner

@willbakst willbakst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Seems functionally complete, mostly minor comments around style.

pytorch_lattice/layers/numerical_calibrator.py Outdated Show resolved Hide resolved
pytorch_lattice/layers/numerical_calibrator.py Outdated Show resolved Hide resolved
pytorch_lattice/layers/numerical_calibrator.py Outdated Show resolved Hide resolved
pytorch_lattice/layers/numerical_calibrator.py Outdated Show resolved Hide resolved
pytorch_lattice/layers/numerical_calibrator.py Outdated Show resolved Hide resolved
tests/layers/test_numerical_calibrator.py Outdated Show resolved Hide resolved
tests/layers/test_numerical_calibrator.py Outdated Show resolved Hide resolved
tests/layers/test_numerical_calibrator.py Outdated Show resolved Hide resolved
tests/layers/test_numerical_calibrator.py Outdated Show resolved Hide resolved
tests/layers/test_numerical_calibrator.py Outdated Show resolved Hide resolved
@willbakst willbakst merged commit b34f5f2 into main Dec 6, 2023
4 checks passed
@willbakst willbakst deleted the numcal_input_keypoints branch December 6, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbakst willbakst willbakst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Learned Interior Input Keypoints For Numerical Calibrators
2 participants
@brianpark0126 @willbakst