Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php8 #95

Merged
merged 4 commits into from Mar 21, 2021
Merged

Php8 #95

merged 4 commits into from Mar 21, 2021

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Feb 4, 2021

Closes #94

@W0rma
Copy link
Contributor Author

W0rma commented Feb 4, 2021

@goetas I'm a bit lost when it comes to fixing the tests.

Tests are green if I use jms/serializer-bundle:3.6 but they start failing if I use jms/serializer-bundle:3.7 or higher. Seems like this is related to the changes in schmittjoh/JMSSerializerBundle#803. However I have no clue how to get tests working again. Can you provide some hints?

@tjveldhuizen
Copy link

I tried to debug this for some hours, last week, however I didn't manage to find a solution. It would be nice if we can find a way to fix it, though. This bundle seems to be the last one blocking our upgrade to PHP 8.

Appearantly, in some way the constructor for the metadata_driver-dependency does end up as a class, rather than a callable, which results in a "Function name must be a string" error in \Bazinga\Bundle\HateoasBundle\Tests\DependencyInjection\BazingaHateoasExtensionTest::testLoad. I'm not sure if this is a problem in the test setup, in the code of this bundle, or in the serializer. Maybe somebody has a clue about that?

@pamil pamil mentioned this pull request Mar 19, 2021
27 tasks
@tjveldhuizen
Copy link

tjveldhuizen commented Mar 20, 2021

The problem seems to be unrelated tot this specific PR, since it also exists in the current 2.1.0-version of this bundle. It is related to a specific version of the JMS/metadata-package: https://github.com/schmittjoh/metadata/releases/tag/2.3.0, so merged PR schmittjoh/metadata#92.

@goetas goetas merged commit 44e06dc into willdurand:master Mar 21, 2021
@W0rma W0rma deleted the php8 branch October 6, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP8 support
3 participants