Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple files translations for same domain #305

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Fix multiple files translations for same domain #305

merged 1 commit into from
Dec 25, 2020

Conversation

thislg
Copy link
Contributor

@thislg thislg commented Dec 10, 2020

This fixes a bug introduced in 43a51cf.

The issue is translations are overridden for every file: a same domain cannot have translations loaded from several files anymore.

By checking if the array is already set, this behavior is fixed.

@thislg
Copy link
Contributor Author

thislg commented Dec 18, 2020 •
edited
Loading

@stof Could you take a look at this PR please? As you can see here the $translations[$locale][$domain] = array() is now inside a loop so we lose translations from the previous file each iteration.

@monteiro monteiro merged commit 542f3b2 into willdurand:master Dec 25, 2020
@thislg thislg deleted the fix-multiple-files-for-same-domain branch January 4, 2021 11:17
@thislg thislg mentioned this pull request Feb 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thislg @stof @monteiro