Symfony 4 Support #257
Merged
Symfony 4 Support #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaleotti
reviewed
Jan 9, 2018
composer.json
Outdated
| @@ -18,14 +18,14 @@ | |||
| "doctrine/annotations": "~1.0", | |||
| "jms/metadata": "~1.1", | |||
| "jms/serializer": "^1.7", | |||
| "symfony/expression-language": "~2.4 || ~3.0", | |||
| "symfony/expression-language": "~2.4 || ~3.0 || ~4.0"", | |||
There was a problem hiding this comment.
"symfony/expression-language": "~2.4 || ~3.0 || ~4.0",There was a problem hiding this comment.
Bad copy and paste… sorry. Sorted now.
|
can we get rid of the HHVM builds maybe? |
|
@leevigraham can we also remove |
|
thanks @leevigraham |
Closed
|
Please, a new tag for sf4 support can be added? |
|
@neandher could you please open an issue for that so that I will remember? Thanks :) |
|
@willdurand There is already one #259 |
|
@neandher hahaha I am so sorry for that. Looks like, even with an existing issue, I dont do my job correctly... will create this tag today if Internet connection in the train allows! |
|
Nice!!!l \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes copied from #253 with updates based on @willdurand comments.
@willdurand, I understand this is a duplicate PR. Happy to close if you prefer to continue with #253.