Fix: callback being called twice. #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2021
- Adds support for Node14, by doing the following: * Update MongoDB Node Driver to latest (3.6.5) * Removed unecessary event emitters from adapter.receive() * adapter.receive() only calls 'done' callback when 'outs__' stream finishes or rise an error. Previous code was calling callback before finishing the file writing. This was causing some async problems and not passing skipper-adapter-test official tests. * Tests are now using official adapter by sailshq. No tweaks are needed to pass the build.
|
Updated this PR with some updates for Node>=14. Upgraded MongoDB driver to 3.6.5 and switched test adapter for the official repo (skipper-adapter-test). Now all builds should pass. Details in this commit |
Simplified error handler
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a bug that makes
cb()being called twice insideadapter.rm()function.This was causing Parley to pop-up the following warning inside Sails: