Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lua-language-server): rename sumneko_lua -> lua_ls #148

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

notjl
Copy link
Contributor

@notjl notjl commented Feb 12, 2023

Fixes #147

Based from the changes on neovim/nvim-lspconfig#2439

@SpanishPear
Copy link

Thanks!!

@Taaqif
Copy link

Taaqif commented Feb 12, 2023

Eagerly waiting on this to be merged

@Alexis12119
Copy link

Eagerly waiting on this to be merged

Me too :)

DoeringChristian added a commit to DoeringChristian/nvim-config that referenced this pull request Feb 12, 2023
Chris1320 added a commit to Chris1320/SetupGuides-Neovim that referenced this pull request Feb 12, 2023
This commit is based on williamboman/mason-lspconfig.nvim#148

Currently, Mason does not recognize `lua_ls` so this commit is
stil waiting for the PR to be merged.

Signed-off-by: Chris1320 <chris1320is@protonmail.com>
@williamboman

This comment has been minimized.

Copy link
Owner

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What an unfortunate change on their side, imo. This will produce the following, new, warning message from mason-lspconfig for some using require("mason-lspconfig").setup_handlers():

mason-lspconfig.setup_handlers: Received handler for unknown lspconfig server name: sumneko_lua.

@williamboman williamboman merged commit 00a2e88 into williamboman:main Feb 12, 2023
helderberto added a commit to helderberto/dotfiles that referenced this pull request Feb 13, 2023
kuntau added a commit to kuntau/dotfiles that referenced this pull request Feb 14, 2023
@freb
Copy link

freb commented Feb 14, 2023

To help with Googling, for those using lsp-zero and have sumneko_lua in ensure_installed, you will see the following error:

[mason-lspconfig.nvim] Server "sumneko_lua" is not a valid entry in ensure_installed. Make sure to only provide lspconfig server names.

@onntztzf
Copy link

Thanks! What an unfortunate change on their side, imo. This will produce the following, new, warning message from mason-lspconfig for some using require("mason-lspconfig").setup_handlers():

mason-lspconfig.setup_handlers: Received handler for unknown lspconfig server name: sumneko_lua.

So, how do I avoid this warning?🥺

@onntztzf
Copy link

Thanks! What an unfortunate change on their side, imo. This will produce the following, new, warning message from mason-lspconfig for some using require("mason-lspconfig").setup_handlers():

mason-lspconfig.setup_handlers: Received handler for unknown lspconfig server name: sumneko_lua.

So, how do I avoid this warning?🥺

Just uninstall all the sumneko_lua and install lua_ls. Thank you...

zdzolton added a commit to zdzolton/neovimconf that referenced this pull request Feb 15, 2023
kuntau added a commit to kuntau/dotfiles that referenced this pull request Feb 15, 2023
ar1a added a commit to ar1a/nvim-config that referenced this pull request Feb 16, 2023
BruceChanJianLe added a commit to BruceChanJianLe/nvim that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sumneko changed name to LuaLS
9 participants