-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get_available_servers now accepts a filter #25
Conversation
@williamboman, this one will be a bit more tricky, but I think it's quite useful, see williamboman/mason.nvim#86 P.s. I've spent way too long trying to get the annotations for this in a reasonable state, but I'm not sure how you'd want it to be, so feel free to add any suggestions. |
They look good to me! I changed the signature to allow both a string as well as a list of strings, felt more natural to me to allow both variants.
Good catch! Should be easy to incorporate, will look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's look into the TODOs in later PRs. I'll wait with merge until I have your blessing @kylo252, not sure if I messed something up with my changes
Too much copy paste.
Description
Allow
get_available_servers
to accept a query filterThe available keys are
related: williamboman/mason.nvim#86
How has this been tested?
TODOs
parse_packages_from_heuristics
is_valid_server()
, see the test-case in 358f627