Relation to nvim-lsp-installer

[JSchrtke]

Hi there, just saw this recently. I was wondering how this relates to your older 'nvim-lsp-installer'? Is this meant to replace that eventually? Since this can also install lsp servers and such...

[williamboman]

Hello! I opened this repo up for early access and potentially get some feedback on usage, wasn't expecting much attention at first. I'll clarify the idea and rationale behind this plugin (and how it relates to nvim-lsp-installer) soon!

[williamboman]

I'd also like to see if this approach of "linking" executables makes sense for Windows devs, or if it's too foreign/problematic. I've only done cursory testing on Windows and things seem to work perfectly fine 🤷‍♂️

[JSchrtke]

funny you mention that, I'm typing an issue as we speak :D

Tldr: Downloading file "https://github.com/golang/vscode-go/releases/download/v0.34.1/go-0.34.1.vsix"...
...ker\start\mason.nvim/lua/mason/core/installer/linker.lua:44: Link target "C:\Users\js\AppData\Local\nvim-data\mason\packages\go-debug-adapter\go-debug-adapter" does not exist.

I'll leave the issue with the full details, I can also have a look what the problem is during the some time during the weekend

Edit: nice issue template btw, I don't even need to think anymore

[JSchrtke]

I'd also like to see if this approach of "linking" executables makes sense for Windows devs, or if it's too foreign/problematic. I've only done cursory testing on Windows and things seem to work perfectly fine 🤷‍♂️

Sorry, forgot to answer regarding this one. I don't really see an issue with using .cmd/.bat scripts to invoke things. As for lspconfig only expecting .exe files; I assume this is a windows-only issue? As in, can lspconfig handle things like shell scripts to start the server? If so, I think the fix should really be upstream, such that lspconfig can also handle starting a language server via scripts (.cmd/.bat/.ps2). Anyway, I think an issue for keeping track of this is perhaps helpful, rather than this discussion?

[williamboman]

I assume this is a windows-only issue?

If my memory doesn't fail me - it's really only a Window + libuv issue. So any plugins or Neovim builtins that leverages uv_spawn and doesn't make any considerations with regards to .cmd/.bat executables will not be compatible with mason executables. This is very easily remedied by vim.loop.spawn(vim.fn.exepath("<executable>")), as done by null-ls.

As in, can lspconfig handle things like shell scripts to start the server?
If so, I think the fix should really be upstream, such that lspconfig can also handle starting a language server via scripts (.cmd/.bat/.ps2).

lspconfig actually does use the shell to spawn all Node.js/npm-based servers - like cmd.exe /C <executable> (this is akin to how Node.js solves it as well via their high-level process.spawn API). So there's definitely a possibility to do this but the server configs in lspconfig are best-effort and unsupported (according to their README), I doubt they'll be interested in considering this tbh and it's not something I'll chase. I believe they only aim to support the installation method they've provided for each server (which usually is via a system package manager). Also see neovim/neovim#18631 (comment)

Anyway, I think an issue for keeping track of this is perhaps helpful, rather than this discussion?

Maybe that'd be too much admin work, I think I'll settle with "patching" the incompatible lspconfig configurations inside the mason-lspconfig extension - that's easily done.

[JSchrtke]

Alright, sounds like you've got a good solution already then. Feel free to ping me for windows issues, I'd be glad to help.