form.fill does not fill entire space

[JulianBroudy]

Hi there,

I stumbled upon a peculiar behavior.
Filling the space keeps a transparent line on top and on the left of the space.
I suspect this is the bgcolor.

let run = Pts.quickStart( "#pt", "#ff99ee" );
run( (time, ftime)  => { form.fill("green").rect(space.innerBound); });

Result:

Removing the bgcolor ("#ff99ee") when initializing does not help.
What's weird is that when resizing the window in your online editor, it snaps to place and everything looks good.
But anytime the code is run again, same result with lines at the top and left of page.

My end-goal includes more than filling the background only once and so the option to only initialize the bgcolor does not work for me although results with the expected behavior.

[williamngan]

Hi @JulianBroudy , there's a 1px stroke by default. Can you try form.stroke(false).fill(...) or form.fillOnly(...) and see if the problem still persists? Thanks!

[JulianBroudy]

Thanks for the quick response.

I tried each and a combination of both, problem persists:

(This was run on the Pts.js Editor)

For the record, I am actually using a gradient as my background as shown in the example in this documentation.

But I was able to replicate the problem with these:

let run = Pts.quickStart( "#pt", "#ff99ee" );
run( (time, ftime) => { form.fill("green").rect(space.innerBound); });

and so chose to keep it simple rather than complicate it.

[williamngan]

Good catch! This looks like a retina resolution issue.

I think this line is causing the 0.5px gap problem.
https://github.com/williamngan/pts/blob/master/src/Canvas.ts#L208

Most likely this was a fix for the bottom pixel gap in the old versions of browsers. But now the issue has been fixed in the browser, we can probably remove it. 😛

I'll try to make a quick patch today.

[JulianBroudy]

Great, thanks.

And again, your library is AWESOME!

[williamngan]

Thanks! It's now patched in v0.9.5. See if it works :)

[JulianBroudy]

When trying out my website with multiple gradients, it works like a charm.
Thanks a million!

I do have another question I ran into yesterday, it has to do with resizing the canvas, can I ask it here or would you rather I open a new issue for it?

[williamngan]

Glad to hear! Please open a new issue so that we can keep track of it if it's a bug. Thanks Julian.