Conglei horizontal bar #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
reviewed
Aug 29, 2018
| yScale={horizontal ? categoryScale : valueScale} | ||
| margin={{ left: 100, top: 64, bottom: 64 }} | ||
| > | ||
| <PatternLines |
There was a problem hiding this comment.
not sure if you want to reference this or not, I like patterns :) I'd update the id if so, or remove component if not.
| const color = d.fill || callOrValue(fill, d, i); | ||
| const barX = xScale(x(d)) - offset; | ||
| const barPosition = categoryScale(categoryField(d)) - offset; | ||
|
|
||
| return ( | ||
| isDefined(d.y) && ( |
There was a problem hiding this comment.
do you think we should update this to be dependent on horizontal? eg isDefined(horizontal ? d.y : d.x)
|
|
||
| const maxHeight = (yScale.range() || [0])[0]; | ||
| const offset = xScale.offset || 0; | ||
| const maxBarLength = (valueScale.range() || [0])[0]; |
There was a problem hiding this comment.
Math.max(...valueScale.range()) might be a little more robust here
|
@williaster Tests added. PTAL. Thanks! |
williaster
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挃 Breaking Changes
馃弳 Enhancements
Added horizontal control for BarSeries
馃摐 Documentation
馃悰 Bug Fix
馃彔 Internal